linux-kernel - Re: [PATCH] Revert "blk-throttle: Fix IO hang for a corner case"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zw6CUDg1xfQk12Ah@slm.duckdns.org>
Date: Tue, 15 Oct 2024 04:55:12 -1000
From: Tejun Heo <tj@...nel.org>
To: Xiuhong Wang <xiuhong.wang@...soc.com>
Cc: josef@...icpanda.com, axboe@...nel.dk, cgroups@...r.kernel.org,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	niuzhiguo84@...il.com, ke.wang@...soc.com,
	xiuhong.wang.cn@...il.com
Subject: Re: [PATCH] Revert "blk-throttle: Fix IO hang for a corner case"

On Fri, Oct 11, 2024 at 09:47:24AM +0800, Xiuhong Wang wrote:
> This reverts commit 5b7048b89745c3c5fb4b3080fb7bced61dba2a2b.
> 
> The throtl_adjusted_limit function was removed after
> commit bf20ab538c81 ("blk-throttle: remove
> CONFIG_BLK_DEV_THROTTLING_LOW"), so the problem of not being
> able to scale after setting bps or iops to 1 will not occur.
> So revert this commit that bps/iops can be set to 1.
> 
> Cc: Baolin Wang <baolin.wang@...ux.alibaba.com>
> Cc: Yu Kuai <yukuai3@...wei.com>
> Signed-off-by: Xiuhong Wang <xiuhong.wang@...soc.com>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@...soc.com>

Please update the description to clarify that it's mostly a cleanup. Other
than that:

  Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun