linux-kernel - Re: [PATCH] Revert "blk-throttle: Fix IO hang for a corner case"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a7cb48f-e3a2-8583-151b-423f85aabd17@huaweicloud.com>
Date: Tue, 15 Oct 2024 19:12:52 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Xiuhong Wang <xiuhong.wang@...soc.com>, tj@...nel.org,
 josef@...icpanda.com, axboe@...nel.dk, cgroups@...r.kernel.org,
 linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: niuzhiguo84@...il.com, ke.wang@...soc.com, xiuhong.wang.cn@...il.com,
 "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH] Revert "blk-throttle: Fix IO hang for a corner case"

在 2024/10/11 9:47, Xiuhong Wang 写道:
> This reverts commit 5b7048b89745c3c5fb4b3080fb7bced61dba2a2b.
> 
> The throtl_adjusted_limit function was removed after
> commit bf20ab538c81 ("blk-throttle: remove
> CONFIG_BLK_DEV_THROTTLING_LOW"), so the problem of not being
> able to scale after setting bps or iops to 1 will not occur.
> So revert this commit that bps/iops can be set to 1.
> 
> Cc: Baolin Wang <baolin.wang@...ux.alibaba.com>
> Cc: Yu Kuai <yukuai3@...wei.com>
> Signed-off-by: Xiuhong Wang <xiuhong.wang@...soc.com>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@...soc.com>
> ---
>   block/blk-throttle.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
LGRM
Reviewed-by: Yu Kuai <yukuai3@...wei.com>

> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 2c4192e12efa..443d1f47c2ce 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -1485,13 +1485,13 @@ static ssize_t tg_set_limit(struct kernfs_open_file *of,
>   			goto out_finish;
>   
>   		ret = -EINVAL;
> -		if (!strcmp(tok, "rbps") && val > 1)
> +		if (!strcmp(tok, "rbps"))
>   			v[0] = val;
> -		else if (!strcmp(tok, "wbps") && val > 1)
> +		else if (!strcmp(tok, "wbps"))
>   			v[1] = val;
> -		else if (!strcmp(tok, "riops") && val > 1)
> +		else if (!strcmp(tok, "riops"))
>   			v[2] = min_t(u64, val, UINT_MAX);
> -		else if (!strcmp(tok, "wiops") && val > 1)
> +		else if (!strcmp(tok, "wiops"))
>   			v[3] = min_t(u64, val, UINT_MAX);
>   		else
>   			goto out_finish;
>