linux-kernel - Re: [PATCH] firmware: arm_ffa: avoid string-fortify warningn in export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172900588452.967423.9099985566745262812.b4-ty@arm.com>
Date: Tue, 15 Oct 2024 16:27:04 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Sudeep Holla <sudeep.holla@....com>,
	Arnd Bergmann <arnd@...db.de>,
	Cristian Marussi <cristian.marussi@....com>,
	Jens Wiklander <jens.wiklander@...aro.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: arm_ffa: avoid string-fortify warningn in export_uuid()

On Mon, 09 Sep 2024 11:09:24 +0000, Arnd Bergmann wrote:
> Copying to a 16 byte structure into an 8-byte struct member
> causes a compile-time warning:
> 
> In file included from drivers/firmware/arm_ffa/driver.c:25:
> In function 'fortify_memcpy_chk',
>     inlined from 'export_uuid' at include/linux/uuid.h:88:2,
>     inlined from 'ffa_msg_send_direct_req2' at drivers/firmware/arm_ffa/driver.c:488:2:
> include/linux/fortify-string.h:571:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
>   571 |                         __write_overflow_field(p_size_field, size);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> [...]

Sorry for the delay, was trying to see if I can test BE kernel and see if
it needs more fixing. The spec does require all memory region to be LE.
I will do that later, for now I am pulling this as fix for v6.12

Applied to sudeep.holla/linux (for-next/ffa/fixes), thanks!

[1/1] firmware: arm_ffa: avoid string-fortify warningn in export_uuid()
      https://git.kernel.org/sudeep.holla/c/629253b2f6d7
--
Regards,
Sudeep