linux-kernel - Re: [PATCH v5 12/22] media: rzg2l-cru: Inline calculating image size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8sVJiEiJ9Xftb-EfwDZp29KY-8N_qYzR_f=5Mh2GLFmug@mail.gmail.com>
Date: Tue, 15 Oct 2024 18:43:24 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hverkuil-cisco@...all.nl>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v5 12/22] media: rzg2l-cru: Inline calculating image size

Hi Laurent,

Thank you for the review.

On Tue, Oct 15, 2024 at 11:22 AM Laurent Pinchart
<laurent.pinchart@...asonboard.com> wrote:
>
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Fri, Oct 11, 2024 at 06:30:42PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > The `rzg2l_cru_format_sizeimage()` function has been inlined into the
> > `rzg2l_cru_format_align()` function as it has a single caller.
>
> The commit message should use the imperative mood:
>
> Inline the `rzg2l_cru_format_sizeimage()` function into its single
> caller as the function is trivial and is not expected to be called
> anywhere else.
>
I will update the commit message as above.

> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

Cheers,
Prabhakar