linux-kernel - Re: [PATCH v2] dt-bindings: spi: Convert bcm2835-aux-spi.txt to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241015-proactive-backlog-b77c42eef79c@spud>
Date: Tue, 15 Oct 2024 21:25:35 +0100
From: Conor Dooley <conor@...nel.org>
To: Karan Sanghavi <karansanghvi98@...il.com>
Cc: krzysztof.kozlowski@...aro.org, bcm-kernel-feedback-list@...adcom.com,
	broonie@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
	florian.fainelli@...adcom.com, krzysztof.kozlowski+dt@...aro.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-rpi-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
	rjui@...adcom.com, robh+dt@...nel.org, sbranden@...adcom.com,
	skhan@...uxfoundation.org
Subject: Re: [PATCH v2] dt-bindings: spi: Convert bcm2835-aux-spi.txt to

On Tue, Oct 15, 2024 at 06:09:07PM +0000, Karan Sanghavi wrote:
> Converted the brcm,bcm2835-aux-spi.txt file to
> its respective yaml file format.
> 
> Signed-off-by: Karan Sanghavi <karansanghvi98@...il.com>
> ---
> v1->v2 : Made the necessary changes in  the yaml file 
> suggested by Krzysztof Kozlowski
> 
> v1:
> - https://lore.kernel.org/all/Zw1Oj1utiBJ9Sosg@Emma/

I don't understand this patch. How is it converting a text file to
json schema when all you're doing here is deleting stuff from an
existing yaml file?

> 
>  .../bindings/spi/brcm,bcm2835-aux-spi.yaml     | 18 ++----------------
>  1 file changed, 2 insertions(+), 16 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
> index 4c24cf2fe214..f83f71ba78dc 100644
> --- a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
> @@ -9,8 +9,7 @@ title: Broadcom BCM2835 Auxiliary SPI1/2 Controller
>  maintainers:
>    - Karan Sanghavi <karansanghvi98@...il.com>
>  
> -description: |
> -  The BCM2835 contains two forms of SPI master controller. One is known simply as
> +description: The BCM2835 contains two forms of SPI master controller. One is known simply as
>    SPI0, and the other as the "Universal SPI Master," part of the auxiliary block.
>    This binding applies to the SPI1 and SPI2 auxiliary controllers.
>  
> @@ -21,7 +20,6 @@ properties:
>    compatible:
>      enum:
>        - brcm,bcm2835-aux-spi
> -    description: Broadcom BCM2835 Auxiliary SPI controller for SPI1 and SPI2.
>  
>    reg:
>      maxItems: 1
> @@ -30,8 +28,7 @@ properties:
>      maxItems: 1
>  
>    clocks:
> -    items:
> -      - description: Reference to the auxiliary clock driver for the BCM2835.
> +    maxItems: 1
>  
>  required:
>    - compatible
> @@ -53,14 +50,3 @@ examples:
>          #size-cells = <0>;
>      };
>  
> -  - |
> -    #include <dt-bindings/clock/bcm2835-aux.h>
> -    spi@...150c0 {
> -        compatible = "brcm,bcm2835-aux-spi";
> -        reg = <0x7e2150c0 0x40>;
> -        interrupts = <1 29>;
> -        clocks = <&aux_clocks BCM2835_AUX_CLOCK_SPI2>;
> -        #address-cells = <1>;
> -        #size-cells = <0>;
> -    };
> -
> -- 
> 2.43.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)