lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <fe800086-8436-4144-a7cf-e963c0749d7c@linaro.org>
Date: Wed, 16 Oct 2024 12:13:31 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Conor Dooley <conor@...nel.org>, Karan Sanghavi <karansanghvi98@...il.com>
Cc: bcm-kernel-feedback-list@...adcom.com, broonie@...nel.org,
 conor+dt@...nel.org, devicetree@...r.kernel.org,
 florian.fainelli@...adcom.com, krzysztof.kozlowski+dt@...aro.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
 rjui@...adcom.com, robh+dt@...nel.org, sbranden@...adcom.com,
 skhan@...uxfoundation.org
Subject: Re: [PATCH v2] dt-bindings: spi: Convert bcm2835-aux-spi.txt to

On 15/10/2024 22:25, Conor Dooley wrote:
> On Tue, Oct 15, 2024 at 06:09:07PM +0000, Karan Sanghavi wrote:
>> Converted the brcm,bcm2835-aux-spi.txt file to
>> its respective yaml file format.
>>
>> Signed-off-by: Karan Sanghavi <karansanghvi98@...il.com>
>> ---
>> v1->v2 : Made the necessary changes in  the yaml file 
>> suggested by Krzysztof Kozlowski
>>
>> v1:
>> - https://lore.kernel.org/all/Zw1Oj1utiBJ9Sosg@Emma/
> 
> I don't understand this patch. How is it converting a text file to
> json schema when all you're doing here is deleting stuff from an
> existing yaml file?

I guess this is supposed to be v2, but it's all messed up.

Karan,
1. Respond to previous review.
2. Prepare v3 incorporating the review.
3. Properly use Git to amend your commit - proficiency in Git is
basically a requirement and we won't be teaching this here. This is
kernel development, so assumption is that you know how to use Git (and
not Github, these are entirely different things).
4. Send v3, do not attach the email to some other versions/threads
whatever. Just use 'b4' if you have troubles with 'git format-patch'.


Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ