[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241015203728.GA1914063-robh@kernel.org>
Date: Tue, 15 Oct 2024 15:37:28 -0500
From: Rob Herring <robh@...nel.org>
To: Cenk Uluisik <cenk.uluisik@...glemail.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
Chris Morgan <macromorgan@...mail.com>,
Dragan Simic <dsimic@...jaro.org>, Jonas Karlman <jonas@...boo.se>,
Andy Yan <andyshrk@....com>, Tim Lunn <tim@...thertop.org>,
Jagan Teki <jagan@...eble.ai>,
Michael Riesch <michael.riesch@...fvision.net>,
Jimmy Hon <honyuenkwun@...il.com>, Jing Luo <jing@...g.rocks>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: arm: rockchip: Add Orange Pi 5b enum
to Orange Pi 5 entry
On Tue, Oct 15, 2024 at 09:28:35PM +0200, Cenk Uluisik wrote:
> This extends the Xunlong Orange Pi 5 device tree binding with an enum for
> the Orange Pi 5b, which is implemented before the device tree.
>
> How does this board differ from the original Orange Pi 5?
> - the Orange Pi 5 has a M.2 NVMe M-key PCI 2.0x1
> slot (hooked to combphy0_ps) whereas the Orange Pi 5b uses combphy0_ps
> for the WiFi.
> - The Orange Pi 5 with the M.2 socket has a regulator defined hooked to
> "GPIO0_C5" (i.e. PCIE_PWREN_H) whereas the Orange Pi 5B has GPIO0_C5
> hooked to BT_WAKE_HOST.
> - builtin eMMC storage
> - no SPI NOR flash (u-boot, preboot etc. initiates
> from within the eMMC
> storage)
> - ap6275p Wifi module (like the Orange Pi 5 Plus)
> - builtin BlueTooth module
>
> Signed-off-by: Cenk Uluisik <cenk.uluisik@...glemail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Well, still kind of too fast because I just acked v5. Before you send
v7, read the process for adding tags.
You should also read the part on adding change log to your patches.
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 687823e58c22..62bb6587da8f 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1051,7 +1051,9 @@ properties:
>
> - description: Xunlong Orange Pi 5
> items:
> - - const: xunlong,orangepi-5
> + - enum:
> + - xunlong,orangepi-5
> + - xunlong,orangepi-5b
> - const: rockchip,rk3588s
>
> - description: Zkmagic A95X Z2
> --
> 2.46.1
>
Powered by blists - more mailing lists