[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241015213822.8070-1-rodrigo.gobbi.7@gmail.com>
Date: Tue, 15 Oct 2024 18:38:22 -0300
From: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
To: dan.carpenter@...aro.org
Cc: gregkh@...uxfoundation.org,
linux-kernel@...r.kernel.org,
linux-staging@...ts.linux.dev,
philipp.g.hortmann@...il.com,
rodrigo.gobbi.7@...il.com,
~lkcamp/patches@...ts.sr.ht
Subject: [PATCH 1/2] staging: rtl8723bs: change remaining printk to proper api
> No, this isn't right. You'd need to use a mix of dev_dbg() and pr_cont().
> Basically in drivers it should always be dev_ printks except for pr_cont().
Tks, Dan, for the answer and suggestion. In this case, rather the dev_xxx(),
do you think we can go with netdev_dbg() since this is a network driver and around
the rtw_mlme_ext.c is already being used? (actually, I don't see a direct reference for struct device).
If yes, I would mix the netdev_dbg() and pr_cont().
About [2], it is acceptable to remove the statements like I'm proposing?
Tks and regards.
[2] https://lore.kernel.org/linux-staging/20241015014738.41685-1-rodrigo.gobbi.7@gmail.com/T/#m85d88af4dd8158a8e62ccb6c7257478b7de46d95
Powered by blists - more mailing lists