linux-kernel - Re: [PATCH 1/2] staging: rtl8723bs: change remaining printk to proper api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024101608-daycare-exterior-31fd@gregkh>
Date: Wed, 16 Oct 2024 10:00:22 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: dan.carpenter@...aro.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev, philipp.g.hortmann@...il.com,
	~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH 1/2] staging: rtl8723bs: change remaining printk to
 proper api

On Tue, Oct 15, 2024 at 06:38:22PM -0300, Rodrigo Gobbi wrote:
> > No, this isn't right.  You'd need to use a mix of dev_dbg() and pr_cont().
> > Basically in drivers it should always be dev_ printks except for pr_cont().
> 
> Tks, Dan, for the answer and suggestion. In this case, rather the dev_xxx(),
> do you think we can go with netdev_dbg() since this is a network driver and around
> the rtw_mlme_ext.c is already being used? (actually, I don't see a direct reference for struct device).
> If yes, I would mix the netdev_dbg() and pr_cont().

Please use netdev_dbg() for a networking driver.

thanks,

greg k-h