linux-kernel - Re: [RFC 1/2] rwsem: introduce upgrade

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241016080057.43997-1-lizhe.67@bytedance.com>
Date: Wed, 16 Oct 2024 16:00:57 +0800
From: lizhe.67@...edance.com
To: hch@...radead.org
Cc: akpm@...ux-foundation.org,
	boqun.feng@...il.com,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	lizhe.67@...edance.com,
	longman@...hat.com,
	mingo@...hat.com,
	peterz@...radead.org,
	will@...nel.org
Subject: Re: [RFC 1/2] rwsem: introduce upgrade_read interface

On Wed, 16 Oct 2024 00:36:19 -0700, hch@...radead.org wrote:

>> >> +extern int upgrade_read(struct rw_semaphore *sem);
>> >
>> >No need for the extern.  Also please make any new advanced funtionality
>>
>> Sorry I don't understand why extern is not needed. If we remove it,
>> we will encounter the following compilation error:
>
>That sounds like you dropped the entire line above, and not just the
>"extern ".

OK I know what you mean. It is indeed OK to remove "extern", but all function
declarations in the rwsem.h have the "extern" prefix. I think it would be
better to keep it consistent.

Thanks!