linux-kernel - Re: [PATCH v16 09/18] tracing: Add ftrace_fill_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241016083445.df18db7ab09e75b903a94dbe@kernel.org>
Date: Wed, 16 Oct 2024 08:34:45 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>, Steven Rostedt
 <rostedt@...dmis.org>, Florent Revest <revest@...omium.org>,
 linux-trace-kernel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, bpf <bpf@...r.kernel.org>, Alexei
 Starovoitov <ast@...nel.org>, Jiri Olsa <jolsa@...nel.org>, Alan Maguire
 <alan.maguire@...cle.com>, Mark Rutland <mark.rutland@....com>,
 linux-arch@...r.kernel.org, Catalin Marinas <catalin.marinas@....com>, Will
 Deacon <will@...nel.org>, Michael Ellerman <mpe@...erman.id.au>, Nicholas
 Piggin <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>,
 Naveen N Rao <naveen@...nel.org>, Madhavan Srinivasan
 <maddy@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
 <agordeev@...ux.ibm.com>, Christian Borntraeger
 <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Thomas
 Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav
 Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v16 09/18] tracing: Add ftrace_fill_perf_regs() for perf
 event

On Tue, 15 Oct 2024 20:18:02 +0200
Heiko Carstens <hca@...ux.ibm.com> wrote:

> On Tue, Oct 15, 2024 at 10:30:15AM +0900, Masami Hiramatsu (Google) wrote:
> > From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> > 
> > Add ftrace_fill_perf_regs() which should be compatible with the
> > perf_fetch_caller_regs(). In other words, the pt_regs returned from the
> > ftrace_fill_perf_regs() must satisfy 'user_mode(regs) == false' and can be
> > used for stack tracing.
> > 
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> > ---
> >   Changes from previous series: NOTHING, just forward ported.
> > ---
> >  arch/s390/include/asm/ftrace.h    |    5 +++++
> 
> ...
> 
> > diff --git a/arch/s390/include/asm/ftrace.h b/arch/s390/include/asm/ftrace.h
> > index 5c94c1fc1bc1..f1c0e677a325 100644
> > --- a/arch/s390/include/asm/ftrace.h
> > +++ b/arch/s390/include/asm/ftrace.h
> > @@ -76,6 +76,11 @@ ftrace_regs_get_frame_pointer(struct ftrace_regs *fregs)
> >  	return ftrace_regs_get_stack_pointer(fregs);
> >  }
> >  
> > +#define arch_ftrace_fill_perf_regs(fregs, _regs)	 do {		\
> > +		(_regs)->psw.addr = arch_ftrace_regs(fregs)->regs.psw.addr;		\
> > +		(_regs)->gprs[15] = arch_ftrace_regs(fregs)->regs.gprs[15];		\
> > +	} while (0)
> > +
> 
> This misses the feedback I gave for v15:
> https://lore.kernel.org/all/20241009100502.8007-E-hca@linux.ibm.com

Oops, sorry. And thanks for your feedback!

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>