linux-kernel - Re: [PATCH v3 04/22] powerpc/cell: Switch to irq_get_nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y12pndld.fsf@mail.lhotse>
Date: Wed, 16 Oct 2024 10:36:14 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Bart Van Assche <bvanassche@....org>, Thomas Gleixner <tglx@...utronix.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Russell King
 <linux@...linux.org.uk>, linux-kernel@...r.kernel.org, Bart Van Assche
 <bvanassche@....org>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v3 04/22] powerpc/cell: Switch to irq_get_nr_irqs()

Bart Van Assche <bvanassche@....org> writes:
> Use the irq_get_nr_irqs() function instead of the global variable
> 'nr_irqs'. Prepare for changing 'nr_irqs' from an exported global
> variable into a variable with file scope.
>
> Cc: linuxppc-dev@...ts.ozlabs.org
> Signed-off-by: Bart Van Assche <bvanassche@....org>
> ---
>  arch/powerpc/platforms/cell/axon_msi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)

cheers

> diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c
> index 28dc86744cac..d243f7fd8982 100644
> --- a/arch/powerpc/platforms/cell/axon_msi.c
> +++ b/arch/powerpc/platforms/cell/axon_msi.c
> @@ -112,7 +112,7 @@ static void axon_msi_cascade(struct irq_desc *desc)
>  		pr_devel("axon_msi: woff %x roff %x msi %x\n",
>  			  write_offset, msic->read_offset, msi);
>  
> -		if (msi < nr_irqs && irq_get_chip_data(msi) == msic) {
> +		if (msi < irq_get_nr_irqs() && irq_get_chip_data(msi) == msic) {
>  			generic_handle_irq(msi);
>  			msic->fifo_virt[idx] = cpu_to_le32(0xffffffff);
>  		} else {