linux-kernel - Re: [PATCH] kfifo: don't include dma-mapping.h in kfifo.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5b2e5e3-a8d5-4b45-8d56-e99536b85a7f@kernel.org>
Date: Tue, 15 Oct 2024 10:03:42 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: stefani@...bold.net, jassisinghbrar@...il.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kfifo: don't include dma-mapping.h in kfifo.h

On 15. 10. 24, 9:57, Christoph Hellwig wrote:
> On Tue, Oct 15, 2024 at 09:55:06AM +0200, Jiri Slaby wrote:
>>> Because it would not comple with out it.  To be specific: asm/io.h is
>>> where __raw_readl and __raw_writel are defined, and we generally prefer
>>> the Linux over the asm headers.
>>
>> OK, but how does this relate to "kfifo: don't include dma-mapping.h in
>> kfifo.h"?
> 
> Because before that it get io.h pulled in through our batshit crazy
> header depency chain.

Good fix then. But you somehow forgot to mention this in the commit message.

-- 
js
suse labs