lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241015094843.GAZw46e6KKVjigUatc@fat_crate.local>
Date: Tue, 15 Oct 2024 11:48:43 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
Cc: Avadhut Naik <avadhut.naik@....com>, "x86@...nel.org" <x86@...nel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Luck, Tony" <tony.luck@...el.com>,
	"rafael@...nel.org" <rafael@...nel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"mchehab@...nel.org" <mchehab@...nel.org>,
	"james.morse@....com" <james.morse@....com>,
	"airlied@...il.com" <airlied@...il.com>,
	"yazen.ghannam@....com" <yazen.ghannam@....com>,
	"john.allen@....com" <john.allen@....com>,
	"avadnaik@....com" <avadnaik@....com>
Subject: Re: [PATCH v5 1/5] x86/mce: Add wrapper for struct mce to export
 vendor specific info

On Tue, Oct 15, 2024 at 06:53:41AM +0000, Zhuo, Qiuxu wrote:
> The word 'mce' isn't too long. IMHO using 'mce' instead of 'm' as
> a variable name is more meaningful :-).
> 
>     struct mce mce;

No, this is not better. Because sometimes it is ambiguous whether the struct
"mce" is meant or the variable "mce".

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ