linux-kernel - Re: [PATCH v5 1/5] x86/mce: Add wrapper for struct mce to export vendor specific info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86df5bba-1750-4dc9-ba3c-b357f562748c@amd.com>
Date: Tue, 15 Oct 2024 13:14:01 -0500
From: "Naik, Avadhut" <avadnaik@....com>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>, Avadhut Naik
 <avadhut.naik@....com>, "x86@...nel.org" <x86@...nel.org>,
 "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
 "linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
 "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "bp@...en8.de" <bp@...en8.de>, "Luck, Tony" <tony.luck@...el.com>,
 "rafael@...nel.org" <rafael@...nel.org>,
 "tglx@...utronix.de" <tglx@...utronix.de>,
 "mingo@...hat.com" <mingo@...hat.com>,
 "rostedt@...dmis.org" <rostedt@...dmis.org>,
 "lenb@...nel.org" <lenb@...nel.org>, "mchehab@...nel.org"
 <mchehab@...nel.org>, "james.morse@....com" <james.morse@....com>,
 "airlied@...il.com" <airlied@...il.com>,
 "yazen.ghannam@....com" <yazen.ghannam@....com>,
 "john.allen@....com" <john.allen@....com>
Subject: Re: [PATCH v5 1/5] x86/mce: Add wrapper for struct mce to export
 vendor specific info


[...]
On 10/15/2024 01:53, Zhuo, Qiuxu wrote:
>> From: Avadhut Naik <avadhut.naik@....com>
>> [...]
>> [...]
>>  static __always_inline int
>> -__mc_scan_banks(struct mce *m, struct pt_regs *regs, struct mce *final,
>> +__mc_scan_banks(struct mce_hw_err *err, struct pt_regs *regs, struct mce *final,
> 
> The 'final' parameter should also be a pointer to this_cpu_ptr(&hw_errs_seen).
> So, it's the final value with an entire 'mce_hw_err' structure stored to 
> ' hw_errs_seen ',  not just a 'mce' structure got stored in 'hw_errs_seen'.
> 
> So,
>    __mc_scan_banks(struct mce_hw_err *err, struct pt_regs *regs, struct mce_hw_err *final, ...
> 

Thanks for pointing this out. This may require a few other changes too.
Will address them in the next revision.

>>  		unsigned long *toclear, unsigned long *valid_banks, int no_way_out,
>>  		int *worst)
>> [...]

-- 
Thanks,
Avadhut Naik