[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1cf314b3e91779e3353bbcaf8ad13516a00642e3.camel@redhat.com>
Date: Wed, 16 Oct 2024 15:05:10 +0200
From: Philipp Stanner <pstanner@...hat.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, Bjorn
Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] PCI: Convert pdev_sort_resources() to use resource
name helper
On Wed, 2024-10-16 at 15:00 +0300, Ilpo Järvinen wrote:
> Use pci_resource_name() helper in pdev_sort_resources() to print
> resources in user-friendly format.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
> drivers/pci/setup-bus.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index 23082bc0ca37..071c5436b4a5 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -134,6 +134,7 @@ static void pdev_sort_resources(struct pci_dev
> *dev, struct list_head *head)
> int i;
>
> pci_dev_for_each_resource(dev, r, i) {
> + const char *r_name = pci_resource_name(dev, i);
> struct pci_dev_resource *dev_res, *tmp;
> resource_size_t r_align;
> struct list_head *n;
> @@ -146,8 +147,8 @@ static void pdev_sort_resources(struct pci_dev
> *dev, struct list_head *head)
>
> r_align = pci_resource_alignment(dev, r);
> if (!r_align) {
> - pci_warn(dev, "BAR %d: %pR has bogus
> alignment\n",
> - i, r);
> + pci_warn(dev, "%s: %pR has bogus
> alignment\n",
> + r_name, r);
Why do you remove the BAR index number, don't you think this
information is also useful?
One could also consider printing r_align, would that be useful? Note
that there is a similar pci_warn down below in line 1118 that does
print it. Would you want to change that pci_warn()-string, too?
P.
> continue;
> }
>
Powered by blists - more mailing lists