linux-kernel - Re: [PATCH v2] m68k: mcfgpio: Fix incorrect register offset for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f56441c-6ba4-4ef4-9f4b-84496c3414de@linux-m68k.org>
Date: Wed, 16 Oct 2024 23:05:48 +1000
From: Greg Ungerer <gerg@...ux-m68k.org>
To: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>,
 Geert Uytterhoeven <geert@...ux-m68k.org>, Steven King <sfking@...dc.com>
Cc: linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] m68k: mcfgpio: Fix incorrect register offset for
 CONFIG_M5441x

Hi JM,

On 16/10/24 17:24, Jean-Michel Hautbois wrote:
> Fix a typo in the CONFIG_M5441x preprocessor condition, where the GPIO
> register offset was incorrectly set to 8 instead of 0. This prevented
> proper GPIO configuration for m5441x targets.
> 
> Fixes: bea8bcb12da0 ("m68knommu: Add support for the Coldfire m5441x.")
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>

Looks good, thanks for the v2.
Applied to the m68knommu git tree, for-next branch.

Regards
Greg


> ---
> Changes in v2:
> - The commit fixed is not the one in v1
> - Link to v1: https://lore.kernel.org/r/20241016-fix-m5441x-gpio-v1-1-0a29befd4b8d@yoseli.org
> ---
>   arch/m68k/include/asm/mcfgpio.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/include/asm/mcfgpio.h b/arch/m68k/include/asm/mcfgpio.h
> index 019f24439546..9c91ecdafc45 100644
> --- a/arch/m68k/include/asm/mcfgpio.h
> +++ b/arch/m68k/include/asm/mcfgpio.h
> @@ -136,7 +136,7 @@ static inline void gpio_free(unsigned gpio)
>    * read-modify-write as well as those controlled by the EPORT and GPIO modules.
>    */
>   #define MCFGPIO_SCR_START		40
> -#elif defined(CONFIGM5441x)
> +#elif defined(CONFIG_M5441x)
>   /* The m5441x EPORT doesn't have its own GPIO port, uses PORT C */
>   #define MCFGPIO_SCR_START		0
>   #else
> 
> ---
> base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354
> change-id: 20241016-fix-m5441x-gpio-e671833569b4
> 
> Best regards,