linux-kernel - RE: [PATCH v5 2/2] clk: imx95-blk-ctl: Add one clock gate for HSIO block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB8676A91F9594FDB5DE93703D8C462@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date: Wed, 16 Oct 2024 02:55:16 +0000
From: Hongxing Zhu <hongxing.zhu@....com>
To: Alexander Stein <alexander.stein@...tq-group.com>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "abelvesa@...nel.org"
	<abelvesa@...nel.org>, Peng Fan <peng.fan@....com>, "mturquette@...libre.com"
	<mturquette@...libre.com>, "sboyd@...nel.org" <sboyd@...nel.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-clk@...r.kernel.org"
	<linux-clk@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [PATCH v5 2/2] clk: imx95-blk-ctl: Add one clock gate for HSIO
 block

Hi Alexander:

> -----Original Message-----
> From: Alexander Stein <alexander.stein@...tq-group.com>
> Sent: 2024年10月15日 17:19
> To: robh@...nel.org; krzk+dt@...nel.org; conor+dt@...nel.org;
> abelvesa@...nel.org; Peng Fan <peng.fan@....com>;
> mturquette@...libre.com; sboyd@...nel.org; shawnguo@...nel.org;
> s.hauer@...gutronix.de; festevam@...il.com; Hongxing Zhu
> <hongxing.zhu@....com>
> Cc: Hongxing Zhu <hongxing.zhu@....com>; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-clk@...r.kernel.org; imx@...ts.linux.dev; kernel@...gutronix.de
> Subject: Re: [PATCH v5 2/2] clk: imx95-blk-ctl: Add one clock gate for HSIO block
>
> Hi Richard,
>
> Am Dienstag, 15. Oktober 2024, 09:34:04 CEST schrieb Richard Zhu:
> > CREF_EN (Bit6) of LFAST_IO_REG control i.MX95 PCIe REF clock out
> > enable/disable.
> >
> > Add compatible string "nxp,imx95-hsio-blk-ctl" to support PCIe REF
> > clock out gate.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> > Reviewed-by: Frank Li <Frank.Li@....com>
> > Reviewed-by: Peng Fan <peng.fan@....com>
> > ---
> >  drivers/clk/imx/clk-imx95-blk-ctl.c | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/drivers/clk/imx/clk-imx95-blk-ctl.c
> > b/drivers/clk/imx/clk-imx95-blk-ctl.c
> > index 19a62da74be4..25974947ad0c 100644
> > --- a/drivers/clk/imx/clk-imx95-blk-ctl.c
> > +++ b/drivers/clk/imx/clk-imx95-blk-ctl.c
> > @@ -277,6 +277,25 @@ static const struct imx95_blk_ctl_dev_data
> netcmix_dev_data = {
> >     .clk_reg_offset = 0,
> >  };
> >
> > +static const struct imx95_blk_ctl_clk_dev_data hsio_blk_ctl_clk_dev_data[] =
> {
> > +   [0] = {
> > +           .name = "hsio_blk_ctl_clk",
> > +           .parent_names = (const char *[]){ "hsio_pll", },
> > +           .num_parents = 1,
> > +           .reg = 0,
>
> According to RM the register LFAST_IO_REG has offset 0xc0. How does the DT
> node look like?
> If this is the HSIO block control I would have expected this to control the whole
> block.
>
Thanks for your comments.
i.MX95 HSIO_BLK_CTL is a mix of kinds of setting registers of HSIO modules.
For example, Wakeup control of USB, AXI master QoS of USB and PCIe, and so on.
Only LFAST_IO_REG(offset 0xc0) register is used as clock out control.
So, only this register is contained in the commit.

Best Regards
Richard Zhu
> Best regards,
> Alexander
>
> > +           .bit_idx = 6,
> > +           .bit_width = 1,
> > +           .type = CLK_GATE,
> > +           .flags = CLK_SET_RATE_PARENT,
> > +   }
> > +};
> > +
> > +static const struct imx95_blk_ctl_dev_data hsio_blk_ctl_dev_data = {
> > +   .num_clks = 1,
> > +   .clk_dev_data = hsio_blk_ctl_clk_dev_data,
> > +   .clk_reg_offset = 0,
> > +};
> > +
> >  static int imx95_bc_probe(struct platform_device *pdev)  {
> >     struct device *dev = &pdev->dev;
> > @@ -447,6 +466,7 @@ static const struct of_device_id imx95_bc_of_match[]
> = {
> >     { .compatible = "nxp,imx95-display-master-csr", },
> >     { .compatible = "nxp,imx95-lvds-csr", .data = &lvds_csr_dev_data },
> >     { .compatible = "nxp,imx95-display-csr", .data =
> > &dispmix_csr_dev_data },
> > +   { .compatible = "nxp,imx95-hsio-blk-ctl", .data =
> > +&hsio_blk_ctl_dev_data },
> >     { .compatible = "nxp,imx95-vpu-csr", .data = &vpublk_dev_data },
> >     { .compatible = "nxp,imx95-netcmix-blk-ctrl", .data = &netcmix_dev_data},
> >     { /* Sentinel */ },
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-g/
> roup.com%2F&data=05%7C02%7Chongxing.zhu%40nxp.com%7Cd6eebc10596
> 440beb9a008dcecfa6a25%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C638645807490320855%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&s
> data=dwZ8j9yLIr0h1aO0qZYE9xjMrQVXsr1iboa4wDLwmss%3D&reserved=0
>