linux-kernel - Re: [PATCH v3 5/6] s390/uvdevice: Add List Secrets Ext IOCTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410161057.pV9QsHAq-lkp@intel.com>
Date: Wed, 16 Oct 2024 11:13:49 +0800
From: kernel test robot <lkp@...el.com>
To: Steffen Eiden <seiden@...ux.ibm.com>, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Ingo Franzki <ifranzki@...ux.ibm.com>,
	Harald Freudenberger <freude@...ux.ibm.com>,
	Christoph Schlameuss <schlameuss@...ux.ibm.com>,
	Janosch Frank <frankja@...ux.ibm.com>,
	Claudio Imbrenda <imbrenda@...ux.ibm.com>
Subject: Re: [PATCH v3 5/6] s390/uvdevice: Add List Secrets Ext IOCTL

Hi Steffen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on kvms390/next]
[also build test WARNING on s390/features linus/master v6.12-rc3 next-20241015]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Steffen-Eiden/s390-boot-uv-c-Use-a-constant-for-more-data-rc/20241015-193108
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git next
patch link:    https://lore.kernel.org/r/20241015112859.3069210-6-seiden%40linux.ibm.com
patch subject: [PATCH v3 5/6] s390/uvdevice: Add List Secrets Ext IOCTL
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20241016/202410161057.pV9QsHAq-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241016/202410161057.pV9QsHAq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410161057.pV9QsHAq-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/s390/char/uvdevice.c:302: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * The actual list(_ext) IOCTL.


vim +302 drivers/s390/char/uvdevice.c

   300	
   301	/**
 > 302	 * The actual list(_ext) IOCTL.
   303	 * If list_ext is true, the first two bytes of the user buffer set the starting
   304	 * index of the list-UVC.
   305	 */
   306	static int list_secrets(struct uvio_ioctl_cb *uv_ioctl, bool list_ext)
   307	{
   308		void __user *user_buf_arg = (void __user *)uv_ioctl->argument_addr;
   309		u16 __user *user_index = (u16 __user *)uv_ioctl->argument_addr;
   310		u16 start_idx = 0;
   311		u8 *secrets;
   312		int ret = 0;
   313	
   314		BUILD_BUG_ON(UVIO_LIST_SECRETS_LEN != PAGE_SIZE);
   315		if (uv_ioctl->argument_len != UVIO_LIST_SECRETS_LEN)
   316			return -EINVAL;
   317		/* The extended call accepts an u16 index as input */
   318		if (list_ext && get_user(start_idx, user_index))
   319			return -EFAULT;
   320		secrets = (u8 *)get_zeroed_page(GFP_KERNEL);
   321		if (!secrets)
   322			return -ENOMEM;
   323		uv_list_secrets(secrets, start_idx, &uv_ioctl->uv_rc, &uv_ioctl->uv_rrc);
   324		if (copy_to_user(user_buf_arg, secrets, UVIO_LIST_SECRETS_LEN))
   325			ret = -EFAULT;
   326	
   327		free_pages((unsigned long)secrets, 0);
   328		return ret;
   329	}
   330	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki