linux-kernel - Re: [PATCH v3 5/6] s390/uvdevice: Add List Secrets Ext IOCTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cdb1e714-a70f-4bb0-b7b7-c420c9322176@linux.ibm.com>
Date: Wed, 16 Oct 2024 11:06:22 +0200
From: Steffen Eiden <seiden@...ux.ibm.com>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        Ingo Franzki <ifranzki@...ux.ibm.com>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Christoph Schlameuss <schlameuss@...ux.ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>
Subject: Re: [PATCH v3 5/6] s390/uvdevice: Add List Secrets Ext IOCTL



On 10/15/24 2:01 PM, Heiko Carstens wrote:
> On Tue, Oct 15, 2024 at 01:28:58PM +0200, Steffen Eiden wrote:
>> Add an extended List Secrets IOCTL. In contrast to the first list IOCTL
>> this accepts an index as the first two bytes of the provided page as an
>> input. This index is then taken as the index offset for the list UVC to
>> receive later entries for the list. While at it fix some kernel doc
>> issues with the list function.
>>
>> Reviewed-by: Christoph Schlameuss <schlameuss@...ux.ibm.com>
>> Signed-off-by: Steffen Eiden <seiden@...ux.ibm.com>
>> ---
>>   arch/s390/include/uapi/asm/uvdevice.h |  4 ++
>>   drivers/s390/char/uvdevice.c          | 96 +++++++++++++++++++--------
>>   2 files changed, 72 insertions(+), 28 deletions(-)
> 
> ...
> 
>> +/**
>> + * The actual list(_ext) IOCTL.
>> + * If list_ext is true, the first two bytes of the user buffer set the starting
>> + * index of the list-UVC.
>> + */
>> +static int list_secrets(struct uvio_ioctl_cb *uv_ioctl, bool list_ext)
> 
> This is not kernel-doc style :)
Thanks, this should not be kernel doc anyways (nor part of an API). Removing the additional star.

> 
>> +	free_pages((unsigned long)secrets, 0);
>> +	return ret;
> 
> free_page() instead of free_pages()?