linux-kernel - Re: [PATCH] rtc: add prefix modalias for rtc modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d64cba44-db6a-4c44-9a92-10dc4e669a1e@kernel.org>
Date: Wed, 16 Oct 2024 08:14:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: huanglei <huanglei814@....com>, alexandre.belloni@...tlin.com
Cc: linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
 huanglei <huanglei@...inos.cn>
Subject: Re: [PATCH] rtc: add prefix modalias for rtc modules

On 16/10/2024 08:07, huanglei wrote:
> Thank you for your reply.
> 
> However, Most other drivers have already set MODULE_ALIAS,  such as 
> rtc-efi.c have set MODULE_ALIAS("platform:rtc-efi");

That driver might need, but this not. It's not an argument in favor.

> 
> So I think this is necessary. If loaded automatically is required, 
> sometimes it is necessary to match through this alias.
> 
> MODULE_ALIAS adds some more info for the userspace programs. In 
> /lib/modules/VERSION/modules.alias you can see the aliases that were 
> parsed from the modules.

Don't explain what mod alias is. We know.

> 
> In this case running  'modprobe spi:rtc-ds1302' would insert the ds1302 
> module.

Which is wrong. There is proper alias already.

> 
> Now , you can see the difference between applying this patch and not 
> applying it.
> 
> This is not applying this patch,  part of  the modules.alias related to 
> rtc_ds1302/ds1347 rtc：
> 
> alias platform:rtc-ds1286 rtc_ds1286
> alias spi:rtc-ds1305 rtc_ds1305
> alias spi:rtc-ds1390 rtc_ds1390
> alias platform:ds1511 rtc_ds1511
> alias platform:rtc-ds1553 rtc_ds1553
> alias platform:rtc-ds1685 rtc_ds1685
> alias platform:rtc-ds1742 rtc_ds1742
> alias platform:ds2404 rtc_ds2404
> alias platform:rtc-efi rtc_efi
> 
> And this is applying this patch,  part of  the modules.alias related to 
> rtc_ds1302/ds1347 rtc：
> 
> alias platform:rtc-ds1286 rtc_ds1286
> alias spi:rtc-ds1302 rtc_ds1302
> alias spi:rtc-ds1305 rtc_ds1305
> alias spi:ds1347 rtc_ds1347
> alias spi:rtc-ds1390 rtc_ds1390
> alias platform:ds1511 rtc_ds1511
> alias platform:rtc-ds1553 rtc_ds1553
> alias platform:rtc-ds1685 rtc_ds1685
> alias platform:rtc-ds1742 rtc_ds1742
> alias platform:ds2404 rtc_ds2404
> alias platform:rtc-efi rtc_efi
> 
> So, if not applying this patch, use modprobe rtc-ds1302/ds1347 may be 
> not  to load automatically.
> 
> Therefore, it is strongly recommended applying this patch.


NAK. You do not understand aliases and you do not understand what is
already in the driver.

Also, don't top post next time.

Best regards,
Krzysztof