linux-kernel - Re: [PATCH v2 1/6] dt-bindings: arm: cpus: Add Samsung Mongoose M5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5267106-27a3-48e5-9fd3-912b4c62155c@kernel.org>
Date: Wed, 16 Oct 2024 08:17:18 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Igor Belwon <igor.belwon@...tallysanemainliners.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 David Wronek <davidwronek@...il.com>, Sibi Sankar <quic_sibis@...cinc.com>,
 Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: arm: cpus: Add Samsung Mongoose M5

On 15/10/2024 23:02, Igor Belwon wrote:
> Add a compatible for the Samsung Mongoose M5 cores, found in
> the Exynos 990.
> 
> Signed-off-by: Igor Belwon <igor.belwon@...tallysanemainliners.org>
> Acked-by: Rob Herring (Arm) <robh@...nel.org>

I am not going to review untested code, sorry.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof