linux-kernel - RE: [PATCH] scsi: ufs: Use wait-for-reg in HCE init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB657551BF4339F8EB494E0DBDFC462@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Wed, 16 Oct 2024 06:21:22 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: Use wait-for-reg in HCE init

> On 10/14/24 9:57 PM, Avri Altman wrote:
> > Instead of open-coding it.  Code simplification - no functional change.
> 
> Please use full sentences in the patch description.
Done.

> 
> > +     while (retry) {
> 
> Please change this loop from a while-loop into a for-loop.
Done.

> 
> > +             if (!ufshcd_wait_for_register(hba, REG_CONTROLLER_ENABLE,
> CONTROLLER_ENABLE,
> > +                                           CONTROLLER_ENABLE, 1000, 50)) {
> > +                     break;
> >               } else {
> 
> "else" is not needed after a "break" statement, isn't it?
Done.

> 
> > +                     dev_err(hba->dev, "Controller enable failed\n");
> 
> Please fix the grammar of this message, e.g. by changing this message into
> "Enabling controller failed" or "Enabling the controller failed".
Done.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.