linux-kernel - [PATCH] PCI: Constify pci_register_io_range stub fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241016062410.2581152-1-arnd@kernel.org>
Date: Wed, 16 Oct 2024 06:24:04 +0000
From: Arnd Bergmann <arnd@...nel.org>
To: Bjorn Helgaas <bhelgaas@...gle.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	"Rob Herring (Arm)" <robh@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>,
	Dan Williams <dan.j.williams@...el.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Philipp Stanner <pstanner@...hat.com>,
	Johan Hovold <johan+linaro@...nel.org>,
	Reinette Chatre <reinette.chatre@...el.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Damien Le Moal <dlemoal@...nel.org>,
	linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] PCI: Constify pci_register_io_range stub fwnode_handle

From: Arnd Bergmann <arnd@...db.de>

The patch to change the argument types for pci_register_io_range()
only caught one of the two implementations, but missed the empty
version:

drivers/of/address.c: In function 'of_pci_range_to_resource':
drivers/of/address.c:244:45: error: passing argument 1 of 'pci_register_io_range' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
  244 |                 err = pci_register_io_range(&np->fwnode, range->cpu_addr,
      |                                             ^~~~~~~~~~~
In file included from drivers/of/address.c:12:
include/linux/pci.h:1559:49: note: expected 'struct fwnode_handle *' but argument is of type 'const struct fwnode_handle *'
 1559 | int pci_register_io_range(struct fwnode_handle *fwnode, phys_addr_t addr,
      |                           ~~~~~~~~~~~~~~~~~~~~~~^~~~~~

Change this the same way.

Fixes: 6ad99a07e6d2 ("PCI: Constify pci_register_io_range() fwnode_handle")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
If possible, please fold this fixup into the original patch
---
 include/linux/pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index 11421ae5c558..733ff6570e2d 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -2019,7 +2019,7 @@ static inline int pci_request_regions(struct pci_dev *dev, const char *res_name)
 { return -EIO; }
 static inline void pci_release_regions(struct pci_dev *dev) { }
 
-static inline int pci_register_io_range(struct fwnode_handle *fwnode,
+static inline int pci_register_io_range(const struct fwnode_handle *fwnode,
 					phys_addr_t addr, resource_size_t size)
 { return -EINVAL; }
 
-- 
2.39.5