linux-kernel - Re: [PATCH] PCI: Constify pci_register_io_range stub fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65ea27ce-0a0d-4324-945b-1d9fcaafd9e8@kernel.org>
Date: Wed, 16 Oct 2024 17:12:45 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 "Rob Herring (Arm)" <robh@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, Dan Williams <dan.j.williams@...el.com>,
 Dave Jiang <dave.jiang@...el.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Philipp Stanner <pstanner@...hat.com>, Johan Hovold
 <johan+linaro@...nel.org>, Reinette Chatre <reinette.chatre@...el.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: Constify pci_register_io_range stub fwnode_handle

On 10/16/24 3:24 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The patch to change the argument types for pci_register_io_range()
> only caught one of the two implementations, but missed the empty
> version:
> 
> drivers/of/address.c: In function 'of_pci_range_to_resource':
> drivers/of/address.c:244:45: error: passing argument 1 of 'pci_register_io_range' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
>   244 |                 err = pci_register_io_range(&np->fwnode, range->cpu_addr,
>       |                                             ^~~~~~~~~~~
> In file included from drivers/of/address.c:12:
> include/linux/pci.h:1559:49: note: expected 'struct fwnode_handle *' but argument is of type 'const struct fwnode_handle *'
>  1559 | int pci_register_io_range(struct fwnode_handle *fwnode, phys_addr_t addr,
>       |                           ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> 
> Change this the same way.
> 
> Fixes: 6ad99a07e6d2 ("PCI: Constify pci_register_io_range() fwnode_handle")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Looks fine.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

-- 
Damien Le Moal
Western Digital Research