linux-kernel - Re: [PATCH v2 0/5] Add Exynos990 pinctrl and chipid drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <795657e1-5232-494c-9ac5-a62455b0f6f9@kernel.org>
Date: Wed, 16 Oct 2024 09:19:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Igor Belwon <igor.belwon@...tallysanemainliners.org>
Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Tomasz Figa <tomasz.figa@...il.com>,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/5] Add Exynos990 pinctrl and chipid drivers

On 16/10/2024 09:06, Krzysztof Kozlowski wrote:
> On Tue, Oct 15, 2024 at 11:04:45PM +0200, Igor Belwon wrote:
>> Hi folks,
>>
>> This series adds support for the drivers for the Exynos 990 SoC. It
>> consists of the pinctrl driver and the chipid driver. The product ID
>> of this chip for chipid is 0xe9830000. The pinctrl bank types are the
>> same as in the Exynos 850 chip.
>>
>> Changes in v2:
>>  - Moved bindings from SoC bringup commit
>>  - Moved device tree changes from SoC bringup commit
>>  - Ordered pinctrl nodes by unit address in SoC DT
>>  - Moved the exynos990-wakeup-eint binding to the correct if.
> 
> Moved? That's not what I asked for. Are you sure you have this warning
> free? That's a requirement for Samsung (see maintainer profile).

Ah, I see now what you did - you removed the interrupt. That's
surprising. I don't understand why.

Best regards,
Krzysztof