[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ccae9246-1980-4f9a-a4b8-5eaf78de8e5d@yoseli.org>
Date: Wed, 16 Oct 2024 09:20:32 +0200
From: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Greg Ungerer <gerg@...inux.org>, linux-m68k@...ts.linux-m68k.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: mcfgpio: Fix incorrect register offset for
CONFIG_M5441x
Hi Geert,
On 16/10/2024 08:56, Geert Uytterhoeven wrote:
> Hi Jean-Michel,
>
> Thanks for your patch!
>
> On Wed, Oct 16, 2024 at 8:45 AM Jean-Michel Hautbois
> <jeanmichel.hautbois@...eli.org> wrote:
>> Fix a typo in the CONFIG_M5441x preprocessor condition, where the GPIO
>> register offset was incorrectly set to 8 instead of 0. This prevented
>> proper GPIO configuration for m5441x targets.
>>
>> Fixes: 83c6bdb827c9 ("m68knommu: Implement gpio support for m54xx.")
>
> The typo was introduced in a different commit, so the correct tag would be
> Fixes: bea8bcb12da09bd3 ("m68knommu: Add support for the Coldfire m5441x.")
Oh gosh, sorry ! Do you want a v2 or would you amend it ?
Thanks for your fast review !
JM
>
>> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>
>
> Gr{oetje,eeting}s,
>
> Geert
>
Powered by blists - more mailing lists