linux-kernel - Re: [PATCH] staging: gpib: Replace kmalloc/memset with kzalloc for zero initialization.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024101652-reattach-laborer-129a@gregkh>
Date: Wed, 16 Oct 2024 09:55:21 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Rohit Chavan <roheetchavan@...il.com>
Cc: Dave Penkler <dpenkler@...il.com>, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: Replace kmalloc/memset with kzalloc for
 zero initialization.

On Mon, Oct 14, 2024 at 01:29:07PM +0530, Rohit Chavan wrote:
> This patch updates the GPIB driver code by replacing the use of kmalloc
> followed by memset with kzalloc. This change simplifies the memory
> allocation process by ensuring that the allocated memory is zero-initialized
> in a single call, improving code readability and reducing the potential for
> errors related to uninitialized memory.
> 
> Signed-off-by: Rohit Chavan <roheetchavan@...il.com>
> ---
>  drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 3 +--
>  drivers/staging/gpib/cb7210/cb7210.c                 | 3 +--
>  drivers/staging/gpib/gpio/gpib_bitbang.c             | 3 +--
>  drivers/staging/gpib/hp_82335/hp82335.c              | 3 +--
>  drivers/staging/gpib/hp_82341/hp_82341.c             | 3 +--
>  drivers/staging/gpib/ines/ines_gpib.c                | 3 +--
>  drivers/staging/gpib/tnt4882/tnt4882_gpib.c          | 3 +--
>  7 files changed, 7 insertions(+), 14 deletions(-)

You sent 2 patches that do almost the same thing, and have almost the
same subject line, shouldn't they just be merged into 1 patch?  Please
do so and resend it as a v2.

thanks,

greg k-h