linux-kernel - Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024101627-tacking-foothill-cdf9@gregkh>
Date: Wed, 16 Oct 2024 12:51:25 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Philipp Stanner <pstanner@...hat.com>
Cc: Andy Shevchenko <andy@...nel.org>,
	Alvaro Karsz <alvaro.karsz@...id-run.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Jason Wang <jasowang@...hat.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

On Wed, Oct 16, 2024 at 11:22:48AM +0200, Philipp Stanner wrote:
> On Wed, 2024-10-16 at 12:08 +0300, Andy Shevchenko wrote:
> > On Wed, Oct 16, 2024 at 09:25:54AM +0200, Philipp Stanner wrote:
> > > In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed
> > > to
> > > pcim_iomap_regions() is placed on the stack. Neither
> > > pcim_iomap_regions() nor the functions it calls copy that string.
> > > 
> > > Should the string later ever be used, this, consequently, causes
> > > undefined behavior since the stack frame will by then have
> > > disappeared.
> > > 
> > > Fix the bug by allocating the strings on the heap through
> > > devm_kasprintf().
> > 
> > > ---
> > 
> > I haven't found the reason for resending. Can you elaborate here?
> 
> Impatience ;p
> 
> This is not a v2.
> 
> I mean, it's a bug, easy to fix and merge [and it's blocking my other
> PCI work, *cough*]. Should contributors wait longer than 8 days until
> resending in your opinion?

2 weeks is normally the expected response time, but each subsystem might
have other time limites, the documentation should show those that do.

While you wait, take the time to review other pending patches for that
maintainer, that will ensure that your patches move to the top as they
will be the only ones remaining.

thanks,

greg k-h