linux-kernel - Re: [PATCH v2 0/2] driver core: Avoid false-positive errors for intentionally skipped links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <843da504-34bb-4067-85b6-49851a1ff517@nvidia.com>
Date: Wed, 16 Oct 2024 12:19:46 +0100
From: Jon Hunter <jonathanh@...dia.com>
To: Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Saravana Kannan <saravanak@...gle.com>
Cc: kernel@...labora.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] driver core: Avoid false-positive errors for
 intentionally skipped links

On 15/10/2024 22:27, Nícolas F. R. A. Prado wrote:
> This series gets rid of the false-positive errors printed when device
> links are intentionally skipped. Patch 1 commonizes the logic into a
> helper and patch 2 uses that to remove the error.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> ---
> Changes in v2:
> - Added patch 1 introducing the device_link_is_useless() helper and used
>    that in patch 2
> - Link to v1: https://lore.kernel.org/r/20240624-fwdevlink-probed-no-err-v1-1-d1213cd354e2@collabora.com
> 
> ---
> Nícolas F. R. A. Prado (2):
>        driver core: Create device_link_is_useless() helper
>        driver core: Don't log intentional skip of device link creation as error
> 
>   drivers/base/core.c | 28 +++++++++++++++++++---------
>   1 file changed, 19 insertions(+), 9 deletions(-)

Looks good to me. For the series ...

Reviewed-by: Jon Hunter <jonathanh@...dia.com>
Tested-by: Jon Hunter <jonathanh@...dia.com>

Thanks!
Jon

-- 
nvpublic