linux-kernel - Re: [PATCH v2 0/2] driver core: Avoid false-positive errors for intentionally skipped links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5302c079-864f-4eae-a0ad-406533a0e298@notapiano>
Date: Wed, 23 Oct 2024 16:03:30 -0400
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Saravana Kannan <saravanak@...gle.com>
Cc: kernel@...labora.com, linux-kernel@...r.kernel.org,
	Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH v2 0/2] driver core: Avoid false-positive errors for
 intentionally skipped links

On Tue, Oct 15, 2024 at 05:27:16PM -0400, Nícolas F. R. A. Prado wrote:
> This series gets rid of the false-positive errors printed when device
> links are intentionally skipped. Patch 1 commonizes the logic into a
> helper and patch 2 uses that to remove the error.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> ---
> Changes in v2:
> - Added patch 1 introducing the device_link_is_useless() helper and used
>   that in patch 2
> - Link to v1: https://lore.kernel.org/r/20240624-fwdevlink-probed-no-err-v1-1-d1213cd354e2@collabora.com
> 
> ---
> Nícolas F. R. A. Prado (2):
>       driver core: Create device_link_is_useless() helper
>       driver core: Don't log intentional skip of device link creation as error

NACK. It turned out these were real issues, for which fixes have now been
sent: https://lore.kernel.org/all/20241023191339.1491282-1-saravanak@google.com
So let's keep the error log message around since it is useful to detect such
issues.

Thanks,
Nícolas