linux-kernel - Re: 回复: [PATCH v1] riscv: dts: starfive: disable unused csi/camss nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241017-condone-angelic-9d4936f1fd37@spud>
Date: Thu, 17 Oct 2024 18:52:04 +0100
From: Conor Dooley <conor@...nel.org>
To: Changhuang Liang <changhuang.liang@...rfivetech.com>
Cc: "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
	Conor Dooley <conor.dooley@...rochip.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Aurelien Jarno <aurelien@...el32.net>,
	Emil Renner Berthing <kernel@...il.dk>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 回复: [PATCH v1] riscv: dts:
 starfive: disable unused csi/camss nodes

On Thu, Oct 17, 2024 at 05:49:56AM +0000, Changhuang Liang wrote:
> Hi, Conor,
> 
> > Hi, Conor
> > 
> > Thanks for your patch.
> > 
> > > From: Conor Dooley <conor.dooley@...rochip.com>
> > >
> > > Aurelien reported probe failures due to the csi node being enabled
> > > without having a camera attached to it. A camera was in the initial
> > > submissions, but was removed from the dts, as it had not actually been
> > > present on the board, but was from an addon board used by the developer
> > of the relevant drivers.
> > > The non-camera pipeline nodes were not disabled when this happened and
> > > the probe failures are problematic for Debian. Disable them.
> > >
> > > CC: stable@...r.kernel.org
> > > Fixes: 28ecaaa5af192 ("riscv: dts: starfive: jh7110: Add camera
> > > subsystem
> > > nodes")
> > 
> > Here you write it in 13 characters, should be "Fixes: 28ecaaa5af19 ..."
> > 
> 
> After fixing this:
> Reviewed-by: Changhuang Liang <changhuang.liang@...rfivetech.com>

Ye, I know it was 13 not 12. I don't think that's a problem though.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)