[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241017185050.0ed82a03@jic23-huawei>
Date: Thu, 17 Oct 2024 18:50:50 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Alexandru Ardelean <aardelean@...libre.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, krzk+dt@...nel.org, robh@...nel.org,
lars@...afoo.de, michael.hennerich@...log.com, gstols@...libre.com,
dlechner@...libre.com
Subject: Re: [PATCH v7 5/8] iio: adc: ad7606: rework available attributes
for SW channels
On Thu, 19 Sep 2024 16:04:40 +0300
Alexandru Ardelean <aardelean@...libre.com> wrote:
> For SW mode, the oversampling and scales attributes are always present.
> So, they can be implemented via a 'read_avail' hook in iio_info.
>
> For HW mode, it's a bit tricky, as these attributes get assigned based on
> GPIO definitions.
>
> So, for SW mode, we define a separate AD7606_SW_CHANNEL() macro, and use
> that for the SW channels.
> And 'ad7606_info_os_range_and_debug' can be renamed to
> 'ad7606_info_sw_mode' as it is only used for SW mode.
>
> For the 'read_avail' hook, we'll need to allocate the SW scales, so that
> they are just returned userspace without any extra processing.
> The allocation will happen when then ad7606_state struct is allocated.
> The oversampling available parameters don't need any extra processing; they
> can just be passed back to userspace (as they are).
>
> Signed-off-by: Alexandru Ardelean <aardelean@...libre.com>
> ---
> drivers/iio/adc/ad7606.c | 52 ++++++++++++++++++++++++++++++++++---
> drivers/iio/adc/ad7606.h | 32 ++++++++++++++++++++---
> drivers/iio/adc/ad7606_spi. | 0
Magic empty file :(
Sending a patch shortly and already queued up.
Powered by blists - more mailing lists