linux-kernel - Re: [PATCH v7 5/8] iio: adc: ad7606: rework available attributes for SW channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+GgBR8J2b+tctXoHsPUOPWqVcLtX5H4Eqbstyg-g96uqTu94g@mail.gmail.com>
Date: Sat, 19 Oct 2024 19:15:36 +0300
From: Alexandru Ardelean <aardelean@...libre.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, krzk+dt@...nel.org, robh@...nel.org, 
	lars@...afoo.de, michael.hennerich@...log.com, gstols@...libre.com, 
	dlechner@...libre.com
Subject: Re: [PATCH v7 5/8] iio: adc: ad7606: rework available attributes for
 SW channels

On Thu, Oct 17, 2024 at 8:51 PM Jonathan Cameron <jic23@...nel.org> wrote:
>
> On Thu, 19 Sep 2024 16:04:40 +0300
> Alexandru Ardelean <aardelean@...libre.com> wrote:
>
> > For SW mode, the oversampling and scales attributes are always present.
> > So, they can be implemented via a 'read_avail' hook in iio_info.
> >
> > For HW mode, it's a bit tricky, as these attributes get assigned based on
> > GPIO definitions.
> >
> > So, for SW mode, we define a separate AD7606_SW_CHANNEL() macro, and use
> > that for the SW channels.
> > And 'ad7606_info_os_range_and_debug' can be renamed to
> > 'ad7606_info_sw_mode' as it is only used for SW mode.
> >
> > For the 'read_avail' hook, we'll need to allocate the SW scales, so that
> > they are just returned userspace without any extra processing.
> > The allocation will happen when then ad7606_state struct is allocated.
> > The oversampling available parameters don't need any extra processing; they
> > can just be passed back to userspace (as they are).
> >
> > Signed-off-by: Alexandru Ardelean <aardelean@...libre.com>
> > ---
> >  drivers/iio/adc/ad7606.c    | 52 ++++++++++++++++++++++++++++++++++---
> >  drivers/iio/adc/ad7606.h    | 32 ++++++++++++++++++++---
> >  drivers/iio/adc/ad7606_spi. |  0
>
> Magic empty file :(

oops
apologies for that;
this looks like it could be a job for a CI check (or checkpatch?)

>
> Sending a patch shortly and already queued up.