linux-kernel - Re: [PATCH v6 1/5] x86/mce: Add wrapper for struct mce to export vendor specific info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2769569-2f4b-4915-8f00-4c40e1163ef7@amd.com>
Date: Thu, 17 Oct 2024 13:09:31 -0500
From: "Naik, Avadhut" <avadnaik@....com>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>, Avadhut Naik
 <avadhut.naik@....com>, "x86@...nel.org" <x86@...nel.org>,
 "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
 "linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "bp@...en8.de" <bp@...en8.de>, "Luck, Tony" <tony.luck@...el.com>,
 "tglx@...utronix.de" <tglx@...utronix.de>,
 "mingo@...hat.com" <mingo@...hat.com>,
 "rostedt@...dmis.org" <rostedt@...dmis.org>,
 "mchehab@...nel.org" <mchehab@...nel.org>,
 "yazen.ghannam@....com" <yazen.ghannam@....com>,
 "john.allen@....com" <john.allen@....com>
Subject: Re: [PATCH v6 1/5] x86/mce: Add wrapper for struct mce to export
 vendor specific info



On 10/17/2024 01:02, Zhuo, Qiuxu wrote:
>> From: Avadhut Naik <avadhut.naik@....com>
>> [...]
>> --- a/arch/x86/kernel/cpu/mce/core.c
>> +++ b/arch/x86/kernel/cpu/mce/core.c
>> [...]
>> @@ -1506,13 +1528,14 @@ noinstr void do_machine_check(struct pt_regs
>> *regs)
>>
>>  	this_cpu_inc(mce_exception_count);
>>
>> -	mce_gather_info(&m, regs);
>> -	m.tsc = rdtsc();
>> +	mce_gather_info(&err, regs);
>> +	m = &err.m;
>> +	m->tsc = rdtsc();
>>
>> -	final = this_cpu_ptr(&mces_seen);
>> -	*final = m;
>> +	final = this_cpu_ptr(&hw_errs_seen);
>> +	final = &err;
> 
> It's not about getting the 'final' pointer to point to 'err', instead initialize the data it points to with 'err'.
> So, it should be:
> 
>     s/final = &err/*final = err/
> 
My bad here. Will take care of it.
Thanks for pointing it out!
> [...]
> 
> -Qiuxu

-- 
Thanks,
Avadhut Naik