linux-kernel - Re: [PATCH v6 2/5] tracing: Add __print_dynamic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241017095419.2c4a7943@gandalf.local.home>
Date: Thu, 17 Oct 2024 09:54:19 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
Cc: Avadhut Naik <avadhut.naik@....com>, "x86@...nel.org" <x86@...nel.org>,
 "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
 "linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "bp@...en8.de" <bp@...en8.de>, "Luck, Tony" <tony.luck@...el.com>,
 "tglx@...utronix.de" <tglx@...utronix.de>, "mingo@...hat.com"
 <mingo@...hat.com>, "mchehab@...nel.org" <mchehab@...nel.org>,
 "yazen.ghannam@....com" <yazen.ghannam@....com>, "john.allen@....com"
 <john.allen@....com>
Subject: Re: [PATCH v6 2/5] tracing: Add __print_dynamic_array() helper

On Thu, 17 Oct 2024 06:58:30 +0000
"Zhuo, Qiuxu" <qiuxu.zhuo@...el.com> wrote:

> When running the check below: 
> 
>     ${LINUX}/scripts/checkpatch.pl --strict  <this patch> 
> 
> it complains:
> 
>     CHECK: Macro argument 'el_size' may be better as '(el_size)' to avoid precedence issues
>     #36: FILE: include/trace/stages/stage3_trace_output.h:123:
>     +#define __print_dynamic_array(array, el_size)                          \
>     +       ({                                                              \
>     +               __print_array(__get_dynamic_array(array),               \
>     +                             __get_dynamic_array_len(array) / el_size, \
>     +                             el_size);                                 \
>     +       })

For once I actually agree with checkpatch in an include/trace file.

I can send another version for you.

-- Steve