linux-kernel - Re: [PATCH v2 1/2] arm64/lib: Handle CRC-32 alternative in C code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241017023751.GA1780@sol.localdomain>
Date: Wed, 16 Oct 2024 19:37:51 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Ard Biesheuvel <ardb+git@...gle.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, herbert@...dor.apana.org.au,
	will@...nel.org, catalin.marinas@....com,
	Ard Biesheuvel <ardb@...nel.org>, Kees Cook <kees@...nel.org>
Subject: Re: [PATCH v2 1/2] arm64/lib: Handle CRC-32 alternative in C code

On Wed, Oct 16, 2024 at 09:26:42PM +0200, Ard Biesheuvel wrote:
> diff --git a/arch/arm64/lib/crc32.S b/arch/arm64/lib/crc32.S
> index 8340dccff46f..5dac63da4247 100644
> --- a/arch/arm64/lib/crc32.S
> +++ b/arch/arm64/lib/crc32.S
> @@ -136,25 +136,16 @@ CPU_BE( rev16		\reg, \reg	)
>  	.endm
>  
>  	.align		5
> -SYM_FUNC_START(crc32_le)
> -alternative_if_not ARM64_HAS_CRC32
> -	b		crc32_le_base
> -alternative_else_nop_endif

In case you happen to send a new version of this, note that the
#include <asm/alternative.h> can be removed from this file.

- Eric