linux-kernel - Re: [PATCH] md: ensure child flush IO does not affect origin bio->bi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW60RP7B59i7t5fY6vTTpfe4UwQJ+c7HtugCteOH0uzyaw@mail.gmail.com>
Date: Thu, 17 Oct 2024 15:25:05 -0700
From: Song Liu <song@...nel.org>
To: linan666@...weicloud.com
Cc: yukuai3@...wei.com, linux-raid@...r.kernel.org, 
	linux-kernel@...r.kernel.org, yi.zhang@...wei.com, houtao1@...wei.com, 
	yangerkun@...wei.com, zhangxiaoxu5@...wei.com
Subject: Re: [PATCH] md: ensure child flush IO does not affect origin bio->bi_status

On Wed, Sep 18, 2024 at 11:33 PM <linan666@...weicloud.com> wrote:
>
> From: Li Nan <linan122@...wei.com>
>
> When a flush is issued to an RAID array, a child flush IO is created and
> issued for each member disk in the RAID array. Since commit b75197e86e6d
> ("md: Remove flush handling"), each child flush IO has been chained with
> the original bio. As a result, the failure of any child IO could modify
> the bi_status of the original bio, potentially impacting the upper-layer
> filesystem.
>
> Fix the issue by preventing child flush IO from altering the original
> bio->bi_status as before. However, this design introduces a known
> issue: in the event of a power failure, if a flush IO on a member
> disk fails, the upper layers may not be informed. This issue is not easy
> to fix and will not be addressed for the time being in this issue.
>
> Fixes: b75197e86e6d ("md: Remove flush handling")
> Signed-off-by: Li Nan <linan122@...wei.com>

Applied to md-6.12.

Thanks for the fix!
Song