linux-kernel - Re: [PATCH v1] riscv: dts: starfive: disable unused csi/camss nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxCjtK5rE0SZuFvf@aurel32.net>
Date: Thu, 17 Oct 2024 07:42:12 +0200
From: Aurelien Jarno <aurelien@...el32.net>
To: Conor Dooley <conor@...nel.org>
Cc: linux-riscv@...ts.infradead.org,
	Conor Dooley <conor.dooley@...rochip.com>, stable@...r.kernel.org,
	Emil Renner Berthing <kernel@...il.dk>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Changhuang Liang <changhuang.liang@...rfivetech.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] riscv: dts: starfive: disable unused csi/camss nodes

Hi,

On 2024-10-16 21:11, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> Aurelien reported probe failures due to the csi node being enabled
> without having a camera attached to it. A camera was in the initial
> submissions, but was removed from the dts, as it had not actually been
> present on the board, but was from an addon board used by the
> developer of the relevant drivers. The non-camera pipeline nodes were
> not disabled when this happened and the probe failures are problematic
> for Debian. Disable them.
> 
> CC: stable@...r.kernel.org
> Fixes: 28ecaaa5af192 ("riscv: dts: starfive: jh7110: Add camera subsystem nodes")
> Closes: https://lore.kernel.org/all/Zw1-vcN4CoVkfLjU@aurel32.net/
> Reported-by: Aurelien Jarno <aurelien@...el32.net>
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> CC: Emil Renner Berthing <kernel@...il.dk>
> CC: Rob Herring <robh@...nel.org>
> CC: Krzysztof Kozlowski <krzk+dt@...nel.org>
> CC: Conor Dooley <conor+dt@...nel.org>
> CC: Changhuang Liang <changhuang.liang@...rfivetech.com>
> CC: devicetree@...r.kernel.org
> CC: linux-riscv@...ts.infradead.org
> CC: linux-kernel@...r.kernel.org
> ---
>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 --
>  1 file changed, 2 deletions(-)

Thanks for picking up that issue. I confirm this fix the "problem".

To give some more details, the problem for Debian is that it appears as
an error, with the line in red in dmesg or journalctl. However we would
like to be able to provide a kernel with such drivers enabled so that
users with a camera can just use an overlay or patch their device tree.

Tested-by: Aurelien Jarno <aurelien@...el32.net>
Reviewed-by: Aurelien Jarno <aurelien@...el32.net>

Regards
Aurelien
 

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@...el32.net                     http://aurel32.net