linux-kernel - Re: [PATCH v8 4/8] PCI/quirks: Abstract LBMS seen check into own function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241017112957.00003782@Huawei.com>
Date: Thu, 17 Oct 2024 11:29:57 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: <linux-pci@...r.kernel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, "Lorenzo
 Pieralisi" <lorenzo.pieralisi@....com>, Rob Herring <robh@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>, "Maciej W. Rozycki"
	<macro@...am.me.uk>, Lukas Wunner <lukas@...ner.de>, Alexandru Gagniuc
	<mr.nuke.me@...il.com>, Krishna chaitanya chundru <quic_krichai@...cinc.com>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, "Rafael J.
 Wysocki" <rafael@...nel.org>, <linux-pm@...r.kernel.org>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@....com>, <linux-kernel@...r.kernel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>, Amit Kucheria <amitk@...nel.org>,
	Zhang Rui <rui.zhang@...el.com>, Christophe JAILLET
	<christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH v8 4/8] PCI/quirks: Abstract LBMS seen check into own
 function

On Wed,  9 Oct 2024 12:52:19 +0300
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> wrote:

> The Target Speed quirk in pcie_failed_link_retrain() uses the presence
> of LBMS bit as one of the triggering conditions effectively
> monopolizing the use of that bit. An upcoming change will introduce a
> PCIe bandwidth controller which sets up an interrupt to track LBMS. As
> LBMS will be cleared by the interrupt handler, the Target Speed quirk
> will no longer be able to observe LBMS directly.
> 
> As a preparatory step for the change, extract the LBMS seen check into
> own function out of pcie_failed_link_retrain().
extract the LBMS seen check from pcie_failed_link_retrain() into
a new function pcie_lmbs_seen()

perhaps is slightly clearer?
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>