linux-kernel - Re: [PATCH] drm/msm/gpu: Check the status of registration to PM QoS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <545e23ed-85fb-48f1-8d34-58c5f0b6506e@arm.com>
Date: Fri, 18 Oct 2024 15:20:04 +0100
From: Lukasz Luba <lukasz.luba@....com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
 robdclark@...il.com, sean@...rly.run, konradybcio@...nel.org,
 quic_abhinavk@...cinc.com, marijn.suijten@...ainline.org, airlied@...il.com
Subject: Re: [PATCH] drm/msm/gpu: Check the status of registration to PM QoS



On 10/18/24 13:02, Dmitry Baryshkov wrote:
> On Fri, Oct 18, 2024 at 12:18:11PM +0100, Lukasz Luba wrote:
>> There is a need to check the returned value of the registration function.
> 
> Why?

The question can be:
why this driver doesn't check errors from frameworks during the
registration?

Is it a generic practice in that code (I hope not)?

When you check the API doc you will see that this fwk can fail and
return some error and the other functions in driver shouldn't
assume blindly that it was OK.

All other places in the kernel check that return value from
the PM QoS framework.

> 
>> In case of returned error, print that and stop the init process.
>>
>> Fixes: 7c0ffcd40b16 ("drm/msm/gpu: Respect PM QoS constraints")
>> Signed-off-by: Lukasz Luba <lukasz.luba@....com>
>> ---
>>   drivers/gpu/drm/msm/msm_gpu_devfreq.c | 9 +++++++--
>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>
>