linux-kernel - Re: [PATCH] Documentation: English fixes in kgdb/kdb article

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241018174953.GA796860@lichtman.org>
Date: Fri, 18 Oct 2024 17:49:53 +0000
From: Nir Lichtman <nir@...htman.org>
To: Matthew Wilcox <willy@...radead.org>
Cc: jason.wessel@...driver.com, daniel.thompson@...aro.org,
	dianders@...omium.org, corbet@....net, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation: English fixes in kgdb/kdb article

On Fri, Oct 18, 2024 at 06:27:01PM +0100, Matthew Wilcox wrote:
> On Fri, Oct 18, 2024 at 04:31:36PM +0000, Nir Lichtman wrote:
> > -Next you should choose one of more I/O drivers to interconnect debugging
> > +Next you should choose one of the I/O drivers to interconnect the debugging
> 
> Wrong fix ;-)  "one or more".

Will fix in v2 :)

> 
> > @@ -201,7 +201,7 @@ Using loadable module or built-in
> >  Configure kgdboc at runtime with sysfs
> >  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >  
> > -At run time you can enable or disable kgdboc by echoing a parameters
> > +At run time you can enable or disable kgdboc by echoing the parameters
> >  into the sysfs. Here are two examples:
> 
> Maybe "by writing parameters into sysfs"?

Yah, sounds better will fix as well in v2.

> 
> > @@ -631,8 +631,6 @@ automatically changes into kgdb mode.
> >  
> >  	kgdb
> >  
> > -   Now disconnect your terminal program and connect gdb in its place
> > -
> 
> Is there a reason you deleted this?  It seems important.
> 

Yes, this sentence is duplicated twice (with slightly different wording), here and a line below.