[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241018185105.41a2db06@jic23-huawei>
Date: Fri, 18 Oct 2024 18:51:05 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Lars-Peter
Clausen <lars@...afoo.de>, Hans de Goede <hdegoede@...hat.com>, Justin
Weiss <justin@...tinweiss.com>
Subject: Re: [PATCH v1 1/1] iio: gyro: bmg160: Drop most likely fake ACPI
IDs
On Fri, 18 Oct 2024 17:57:32 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> The commits in question do not proove that ACPI IDs exist.
> Quite likely it was a cargo cult addition while doing that
> for DT-based enumeration. Drop most likely fake ACPI IDs.
>
> The to be removed IDs has been checked against the following resources:
> 1) DuckDuckGo
> 2) Google
> 3) MS catalog: https://www.catalog.update.microsoft.com/Search.aspx
> This gives no useful results in regard to DSDT, moreover, the official
> vendor IDs in the registry for Bosh are BSG and BOSC.
>
I'm nervous about Bosch drivers in the wild given recent report
from Justin
https://lore.kernel.org/linux-iio/87jzeboi3g.fsf@justinweiss.com/
Justin, I couldn't find the driver you were referring to for the bmi160,
is it online somewhere?
Also if you have other bosch drivers could you check for these + bmc150
IDs Andy is proposing dropping in:
https://lore.kernel.org/linux-iio/20241018145805.2181682-1-andriy.shevchenko@linux.intel.com/
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> drivers/iio/gyro/bmg160_i2c.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/iio/gyro/bmg160_i2c.c b/drivers/iio/gyro/bmg160_i2c.c
> index 672d0b720f61..a81814df5205 100644
> --- a/drivers/iio/gyro/bmg160_i2c.c
> +++ b/drivers/iio/gyro/bmg160_i2c.c
> @@ -39,8 +39,6 @@ static void bmg160_i2c_remove(struct i2c_client *client)
>
> static const struct acpi_device_id bmg160_acpi_match[] = {
> {"BMG0160", 0},
> - {"BMI055B", 0},
> - {"BMI088B", 0},
> {},
> };
>
Powered by blists - more mailing lists