linux-kernel - Re: [PATCH v1 1/1] iio: gyro: bmg160: Drop most likely fake ACPI IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sestcg1e.fsf@justinweiss.com>
Date: Fri, 18 Oct 2024 13:27:57 -0700
From: Justin Weiss <justin@...tinweiss.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
  linux-iio@...r.kernel.org,  linux-kernel@...r.kernel.org,  Lars-Peter
 Clausen <lars@...afoo.de>,  Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v1 1/1] iio: gyro: bmg160: Drop most likely fake ACPI IDs

Jonathan Cameron <jic23@...nel.org> writes:

> On Fri, 18 Oct 2024 17:57:32 +0300
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
>
>> The commits in question do not proove that ACPI IDs exist.
>> Quite likely it was a cargo cult addition while doing that
>> for DT-based enumeration. Drop most likely fake ACPI IDs.
>> 
>> The to be removed IDs has been checked against the following resources:
>> 1) DuckDuckGo
>> 2) Google
>> 3) MS catalog: https://www.catalog.update.microsoft.com/Search.aspx
>> This gives no useful results in regard to DSDT, moreover, the official
>> vendor IDs in the registry for Bosh are BSG and BOSC.
>> 
>
> I'm nervous about Bosch drivers in the wild given recent report
> from Justin
> https://lore.kernel.org/linux-iio/87jzeboi3g.fsf@justinweiss.com/
>
> Justin, I couldn't find the driver you were referring to for the bmi160,
> is it online somewhere?

Yes, the BMI160/260 Windows driver is on this page:
https://ayaneo.com/support/download

It's at the very bottom, under "AYANEO Universal Gyro Driver." GPD also
has a copy inside their driver pack under the "Drivers & BIOS" tab here:
https://www.gpd.hk/gpdwinminifirmwaredriver, but the download is often
at capacity unless you're signed into Google.

> Also if you have other bosch drivers could you check for these + bmc150
> IDs Andy is proposing dropping in:
>
> https://lore.kernel.org/linux-iio/20241018145805.2181682-1-andriy.shevchenko@linux.intel.com/

Unfortunately, the 160/260 driver is the only one I have. I wanted gyro
support in Linux for a handheld PC I bought, and it was the IMU that
happened to be inside.

Justin

>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> ---
>>  drivers/iio/gyro/bmg160_i2c.c | 2 --
>>  1 file changed, 2 deletions(-)
>> 
>> diff --git a/drivers/iio/gyro/bmg160_i2c.c b/drivers/iio/gyro/bmg160_i2c.c
>> index 672d0b720f61..a81814df5205 100644
>> --- a/drivers/iio/gyro/bmg160_i2c.c
>> +++ b/drivers/iio/gyro/bmg160_i2c.c
>> @@ -39,8 +39,6 @@ static void bmg160_i2c_remove(struct i2c_client *client)
>>  
>>  static const struct acpi_device_id bmg160_acpi_match[] = {
>>  	{"BMG0160", 0},
>> -	{"BMI055B", 0},
>> -	{"BMI088B", 0},
>>  	{},
>>  };
>>