linux-kernel - Re: [PATCH] ipmr: Don't mark ip6mr_rtnl_msg_handlers as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <95170855-21fc-45b4-a393-176883f7dd52@app.fastmail.com>
Date: Fri, 18 Oct 2024 19:09:10 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: "Kuniyuki Iwashima" <kuniyu@...zon.com>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Alexander Lobakin" <aleksander.lobakin@...el.com>,
 "Kunwu Chan" <chentao@...inos.cn>, "David S . Miller" <davem@...emloft.net>,
 "David Ahern" <dsahern@...nel.org>, "Eric Dumazet" <edumazet@...gle.com>,
 "Jakub Kicinski" <kuba@...nel.org>, linux-kernel@...r.kernel.org,
 "Li Zetao" <lizetao1@...wei.com>, Netdev <netdev@...r.kernel.org>,
 "Paolo Abeni" <pabeni@...hat.com>
Subject: Re: [PATCH] ipmr: Don't mark ip6mr_rtnl_msg_handlers as __initconst

On Fri, Oct 18, 2024, at 16:31, Kuniyuki Iwashima wrote:
> From: Arnd Bergmann <arnd@...nel.org>
> Date: Fri, 18 Oct 2024 15:12:14 +0000
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> This gets referenced by the ip6_mr_cleanup function, so it must not be
>> discarded early:
>> 
>> WARNING: modpost: vmlinux: section mismatch in reference: ip6_mr_cleanup+0x14 (section: .exit.text) -> ip6mr_rtnl_msg_handlers (section: .init.rodata)
>> ERROR: modpost: Section mismatches detected.
>> Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
>> 
>> Fixes: 3ac84e31b33e ("ipmr: Use rtnl_register_many().")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Hi,
>
> I posted this yesterday.
> https://lore.kernel.org/netdev/20241017174732.39487-1-kuniyu@amazon.com/

Right, your may be better then. I was confused by the
function name suggesting that this would be called in the
module_exit path, but I now see that it is only called
at init time, so that works.

     Arnd