linux-kernel - Re: [PATCH] ipmr: Don't mark ip6mr_rtnl_msg_handlers as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241018191739.5158-1-kuniyu@amazon.com>
Date: Fri, 18 Oct 2024 12:17:39 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <arnd@...db.de>
CC: <aleksander.lobakin@...el.com>, <arnd@...nel.org>, <chentao@...inos.cn>,
	<davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <linux-kernel@...r.kernel.org>,
	<lizetao1@...wei.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH] ipmr: Don't mark ip6mr_rtnl_msg_handlers as __initconst

From: "Arnd Bergmann" <arnd@...db.de>
Date: Fri, 18 Oct 2024 19:09:10 +0000
> On Fri, Oct 18, 2024, at 16:31, Kuniyuki Iwashima wrote:
> > From: Arnd Bergmann <arnd@...nel.org>
> > Date: Fri, 18 Oct 2024 15:12:14 +0000
> >> From: Arnd Bergmann <arnd@...db.de>
> >> 
> >> This gets referenced by the ip6_mr_cleanup function, so it must not be
> >> discarded early:
> >> 
> >> WARNING: modpost: vmlinux: section mismatch in reference: ip6_mr_cleanup+0x14 (section: .exit.text) -> ip6mr_rtnl_msg_handlers (section: .init.rodata)
> >> ERROR: modpost: Section mismatches detected.
> >> Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
> >> 
> >> Fixes: 3ac84e31b33e ("ipmr: Use rtnl_register_many().")
> >> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> >
> > Hi,
> >
> > I posted this yesterday.
> > https://lore.kernel.org/netdev/20241017174732.39487-1-kuniyu@amazon.com/
> 
> Right, your may be better then. I was confused by the
> function name suggesting that this would be called in the
> module_exit path, but I now see that it is only called
> at init time, so that works.

Since the commit below, IPv6 has lost unloadability, and such cleanup
functions are only called from init path now.


commit 8ce440610357b77587433d0df647cea69a6890a8
Author: Cong Wang <amwang@...hat.com>
Date:   Sat Sep 21 11:12:21 2013 +0800

    ipv6: do not allow ipv6 module to be removed