linux-kernel - Re: [PATCH v3 4/5] selftests/mseal: add more tests for mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c9796ff-ccf8-404b-917f-57b48b42f6d6@linuxfoundation.org>
Date: Fri, 18 Oct 2024 14:28:54 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Jeff Xu <jeffxu@...omium.org>
Cc: Mark Brown <broonie@...nel.org>,
 Muhammad Usama Anjum <usama.anjum@...labora.com>, akpm@...ux-foundation.org,
 linux-kselftest@...r.kernel.org, linux-mm@...ck.org,
 linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
 pedro.falcato@...il.com, willy@...radead.org, vbabka@...e.cz,
 Liam.Howlett@...cle.com, rientjes@...gle.com, keescook@...omium.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3 4/5] selftests/mseal: add more tests for mmap

On 10/18/24 13:52, Lorenzo Stoakes wrote:
> On Fri, Oct 18, 2024 at 12:32:37PM -0700, Jeff Xu wrote:
>>> when they encouter a failure, the pattern I sketched in my earlier
>>> message, or switch to kselftest_harness.h (like I say I don't know if
>>> the fork()ing is an issue for these tests).  If I had to have a macro
>>> it'd probably be something like mseal_assert().
>>>
>> I can go with mseal_assert, the original macro is used  by mseal_test
>> itself, and only intended as such.
>>
>> If changing name to mseal_assert() is acceptable, this seems to be a
>> minimum change and I'm happy with that.
> 
> No.
> 

Jeff,

Please pay attention to the feedback you have been receiving so far from
Mark and others about using the existing kselftest framework for reporting
results and don't reinvent wheel.

We have two frameworks to choose from - they both have been in use for
quiet sometime by tests. If there is a need to add new functions and
fix the existing ones that should happen in kselftest_harness.h or
kselftest.h. We keep fixing problem and enhancing them as needed.

With my kselfest and framework maintainer hat on, I don't want to see
yet another framework emerging which is buried in tests.

thanks,
-- Shuah