linux-kernel - Re: [PATCH 2/2] pinctrl: qcom: add support for TLMM on SAR2130P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s7tc7cq42qeuj3d63is2dmq2szzq3ezlvv7zpd26qc7boyldnk@yvofxbx3kfbr>
Date: Fri, 18 Oct 2024 06:34:30 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Mayank Grover <groverm@...eaurora.org>
Subject: Re: [PATCH 2/2] pinctrl: qcom: add support for TLMM on SAR2130P

Hello Dmitry,

On Thu, Oct 17, 2024 at 07:15:46PM +0300, Dmitry Baryshkov wrote:
> +static struct platform_driver sar2130p_tlmm_driver = {
> +	.driver = {
> +		.name = "sar2130p-tlmm",
> +		.of_match_table = sar2130p_tlmm_of_match,
> +	},
> +	.probe = sar2130p_tlmm_probe,
> +	.remove_new = msm_pinctrl_remove,
> +};

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers. Please just drop "_new".

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)