linux-kernel - Re: [PATCH v1 2/2] i2c: spacemit: add support for SpacemiT K1 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e457d0f6-8403-40a2-afb4-c3d3d4a25ae8@kernel.org>
Date: Fri, 18 Oct 2024 08:05:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Troy Mitchell <troymitchell988@...il.com>, andi.shyti@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] i2c: spacemit: add support for SpacemiT K1 SoC

On 18/10/2024 07:17, Troy Mitchell wrote:
> 
> On 2024/10/15 16:08, Krzysztof Kozlowski wrote:
>>> +	disable_irq(i2c->irq);
>> Why?
> 
> I just want to turn on the interrupt when the transmission starts,
> and turn off the interrupt after the transmission ends.
> The interrupt shutdown in the probe is a starting point
> before the transmission starts.
> 
> Is this reasonable? If not, I will modify it.

You cut so much context I don't know what this refers to. I will leave
it to I2C maintainers, but toggling interrupt on probe is weird.
Toggling it for every transfer as well.

Best regards,
Krzysztof