[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6545eabc-1956-4e55-be99-e0b35650a773@gmail.com>
Date: Fri, 18 Oct 2024 16:33:25 +0800
From: Troy Mitchell <troymitchell988@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, andi.shyti@...nel.org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
troymitchell988@...il.com
Cc: linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] i2c: spacemit: add support for SpacemiT K1 SoC
On 2024/10/18 14:05, Krzysztof Kozlowski wrote:
> On 18/10/2024 07:17, Troy Mitchell wrote:
>>
>> On 2024/10/15 16:08, Krzysztof Kozlowski wrote:
>>>> + disable_irq(i2c->irq);
>>> Why?
>>
>> I just want to turn on the interrupt when the transmission starts,
>> and turn off the interrupt after the transmission ends.
>> The interrupt shutdown in the probe is a starting point
>> before the transmission starts.
>>
>> Is this reasonable? If not, I will modify it.
>
> You cut so much context I don't know what this refers to. I will leave
> it to I2C maintainers, but toggling interrupt on probe is weird.
> Toggling it for every transfer as well.
>
> Best regards,
> Krzysztof
>
In addition to this problem, should I send v2 after
I fix all the errors pointed out in the email,
or should I wait for I2C maintainers?
Powered by blists - more mailing lists